Hi, Shu-hsiang:
On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces utility files for the MediaTek ISP7.x camsys driver. These
> utilities provide essential platform definitions, debugging tools, and
> management functions to support ISP operations and SCP communication.
> Key functionalities include:
> 1.Hardware pipeline and register definitions for managing image
> processing modules.
> 2.DMA debugging utilities and buffer management functions.
> 3.Definitions of supported image formats for proper data handling.
> 4.IPI and SCP communication structures for module state management and
> configuring ISP.
> 5.Metadata parameters for configuring image processing.
>
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---
[snip]
> +/*
> + * The IPI command enumeration.
> + */
> +enum mtkcam_ipi_cmds {
> + /* request for a new streaming: mtkcam_ipi_session_param */
> + CAM_CMD_CREATE_SESSION,
> + /* config the stream: mtkcam_ipi_config_param */
> + CAM_CMD_CONFIG,
> + /* per-frame: mtkcam_ipi_frame_param */
> + CAM_CMD_FRAME,
> + /* release certain streaming: mtkcam_ipi_session_param */
> + CAM_CMD_DESTROY_SESSION,
> + /* ack: mtkcam_ipi_ack_info */
> + CAM_CMD_ACK,
> + CAM_CMD_RESERVED,
It's not necessary to have CAM_CMD_RESERVED. Drop it.
Regards,
CK
> +};
> +
