Hi, Shu-hsiang:
On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces utility files for the MediaTek ISP7.x camsys driver. These
> utilities provide essential platform definitions, debugging tools, and
> management functions to support ISP operations and SCP communication.
> Key functionalities include:
> 1.Hardware pipeline and register definitions for managing image
> processing modules.
> 2.DMA debugging utilities and buffer management functions.
> 3.Definitions of supported image formats for proper data handling.
> 4.IPI and SCP communication structures for module state management and
> configuring ISP.
> 5.Metadata parameters for configuring image processing.
>
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---
[snip]
> +struct mtkcam_ipi_config_param {
> + u8 flags;
> + struct mtkcam_ipi_input_param input;
> + u8 n_maps;
Driver always set n_maps = 1, when would it be other value?
If it is always 1, drop it and let firmware just support 1.
> + /* maximum # of pipes per stream */
> + struct mtkcam_ipi_hw_mapping maps[6];
> + /* sub_ratio:8, valid number: 8 */
> + u16 valid_numbers[MTKCAM_IPI_FBCX_LAST];
valid_numbers is useless, so drop it.
Regards,
CK
> + u8 sw_feature;
> +} __packed;
> +
