On Thu, Nov 14, 2024 at 04:25:45AM +0000, Renjiang Han (QUIC) wrote:
> On Thu 11/14/2024 2:01 AM, Dmitry Baryshkov wrote:
> > On Tue, Nov 12, 2024 at 05:17:58PM +0530, Renjiang Han wrote:
> > > Initialize the platform data and enable venus driver probe of QCS615
> > > SoC.
> > >
> > > Signed-off-by: Renjiang Han <quic_renjiang@xxxxxxxxxxx>
> > > ---
> > > drivers/media/platform/qcom/venus/core.c | 50
> > > ++++++++++++++++++++++++++++++++
> > > 1 file changed, 50 insertions(+)
> > >
> > > diff --git a/drivers/media/platform/qcom/venus/core.c
> > > b/drivers/media/platform/qcom/venus/core.c
> > > index
> > > 423deb5e94dcb193974da23f9bd2d905bfeab2d9..39d8bcf62fe4f72674746b75994c
> > > ce6cbaee94eb 100644
> > > --- a/drivers/media/platform/qcom/venus/core.c
> > > +++ b/drivers/media/platform/qcom/venus/core.c
> > > @@ -630,6 +630,55 @@ static const struct venus_resources msm8998_res = {
> > > .fwname = "qcom/venus-4.4/venus.mbn", };
> > >
> > > +static const struct freq_tbl qcs615_freq_table[] = {
> > > + { 0, 460000000 },
> > > + { 0, 410000000 },
> > > + { 0, 380000000 },
> > > + { 0, 300000000 },
> > > + { 0, 240000000 },
> > > + { 0, 133333333 },
> > > +};
> > > +
> > > +static const struct bw_tbl qcs615_bw_table_enc[] = {
> > > + { 972000, 951000, 0, 1434000, 0 }, /* 3840x2160@30 */
> > > + { 489600, 723000, 0, 973000, 0 }, /* 1920x1080@60 */
> > > + { 244800, 370000, 0, 495000, 0 }, /* 1920x1080@30 */
> > > +};
> > > +
> > > +static const struct bw_tbl qcs615_bw_table_dec[] = {
> > > + { 1036800, 1987000, 0, 2797000, 0 }, /* 4096x2160@30 */
> > > + { 489600, 1040000, 0, 1298000, 0 }, /* 1920x1080@60 */
> > > + { 244800, 530000, 0, 659000, 0 }, /* 1920x1080@30 */
> > > +};
> > > +
> > > +static const struct venus_resources qcs615_res = {
> > > + .freq_tbl = qcs615_freq_table,
> > > + .freq_tbl_size = ARRAY_SIZE(qcs615_freq_table),
> > > + .bw_tbl_enc = qcs615_bw_table_enc,
> > > + .bw_tbl_enc_size = ARRAY_SIZE(qcs615_bw_table_enc),
> > > + .bw_tbl_dec = qcs615_bw_table_dec,
> > > + .bw_tbl_dec_size = ARRAY_SIZE(qcs615_bw_table_dec),
> > > + .clks = {"core", "iface", "bus" },
> > > + .clks_num = 3,
> > > + .vcodec0_clks = { "vcodec0_core", "vcodec0_bus" },
> > > + .vcodec_clks_num = 2,
> > > + .vcodec_pmdomains = (const char *[]) { "venus", "vcodec0" },
> > > + .vcodec_pmdomains_num = 2,
> > > + .opp_pmdomain = (const char *[]) { "cx" },
> > > + .vcodec_num = 1,
> > > + .hfi_version = HFI_VERSION_4XX,
> > > + .vpu_version = VPU_VERSION_AR50,
> > > + .vmem_id = VIDC_RESOURCE_NONE,
> > > + .vmem_size = 0,
> > > + .vmem_addr = 0,
> > > + .dma_mask = 0xe0000000 - 1,
> > > + .cp_start = 0,
> > > + .cp_size = 0x70800000,
> > > + .cp_nonpixel_start = 0x1000000,
> > > + .cp_nonpixel_size = 0x24800000,
> > > + .fwname = "qcom/venus-5.4/venus_s6.mbn",
>
> > Why does it need a separate firmware file?
>
> SC7180, qcs615 can be enabled on same firmware ideally, but due to a different signing for qcs615, it takes a separate bin (venus_s6.mbn).
Continuing discussion in the linux-firmware@ thread.
--
With best wishes
Dmitry
