Re: [PATCH v5 05/28] media: iris: implement video firmware load/unload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/13/2024 9:26 PM, Bryan O'Donoghue wrote:
> On 13/11/2024 05:20, Dikshita Agarwal wrote:
>>>> +err_put_node:
>>>> +    of_node_put(node);
>>> remove
>> Sure, Will make the change.
>> but are we just trying to avoid using "goto" here?
>>
>> Thanks,
>> Dikshita
> 
> Currently you'd be leaking because you only do the put on the error path.
> 
>> +    rmem = of_reserved_mem_lookup(node);
> 
> of_node_put(node);
> 
Ah, Right!
Will fix this

Thanks,
Dikshita
> ---
> bod




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux