On 11/13/24 17:32, barnabas.czeman@xxxxxxxxxxxxxx wrote:
On 2024-11-13 16:23, Bryan O'Donoghue wrote:
On 13/11/2024 13:28, Vladimir Zapolskiy wrote:
So, we have to rely on the documentation here. Bryan, can you please
check, if VDDA_MIPI_CSI pad on MSM8916 and/or MSM8953 is related to
CSIPHY or CSID power supply? Thank you in advance.
No there's really no indication in the documents I have how the input
gets routed internally, CSID, CSIPHY, both.. not clear.
I think Barnabás is right, the best source of information we have for
this one is the downstream dtsi => CSID.
I have found the regulator also in downstream msm_csid driver i hope it
helps a bit.
https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/drivers/media/platform/msm/camera_v2/sensor/csid/msm_csid.c#L73
Agreed, since the documentation is ambiguous about the voltage supply,
the best deal is to follow the downstream code here.
Please fix the review findings in the dt-bindings, and rebase the driver
changes on top of the linux-next, also please consider to add CCI and
CAMSS device tree nodes into the msm8953.dtsi file.
--
Best wishes,
Vladimir
