Hi Ricardo,
On Fri, Nov 08, 2024 at 08:25:48PM +0000, Ricardo Ribalda wrote:
> Make an ancillary device between the streaming subdevice and the GPIO
s/device/link/
> subdevice.
Either subdev or sub-device. Same above.
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> drivers/media/usb/uvc/uvc_entity.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_entity.c b/drivers/media/usb/uvc/uvc_entity.c
> index c1b69f9eaa56..dad77b96fe16 100644
> --- a/drivers/media/usb/uvc/uvc_entity.c
> +++ b/drivers/media/usb/uvc/uvc_entity.c
> @@ -53,6 +53,16 @@ static int uvc_mc_create_links(struct uvc_video_chain *chain,
> return ret;
> }
>
> + /* Create ancillary link for the GPIO. */
> + if (chain->dev->gpio_unit && UVC_ENTITY_TYPE(entity) == UVC_ITT_CAMERA) {
This seems to be over 80 for no apparent reason.
> + struct media_link *link;
> +
> + link = media_create_ancillary_link(sink,
> + &chain->dev->gpio_unit->subdev.entity);
And following the alignment rules would push this over 80. I have no
problem with that.
> + if (IS_ERR(link))
> + return PTR_ERR(link);
> + }
> +
> return 0;
> }
>
>
--
Regards,
Sakari Ailus
