Hi Jacopo, On Tue, Oct 22, 2024 at 05:08:21PM +0200, Jacopo Mondi wrote: > Hi Sakari > > On Fri, Oct 11, 2024 at 10:55:32AM +0300, Sakari Ailus wrote: > > Rework embedded data documentation by removing the reference to the pixel > > data stream. The specific documentation of the embedded data interface > > will be elsewhere. > > I'm not sure how to interpret the last phrase. What specific > documentation ? The formats description ? Should this be part of the The embedded data interface. It'll be used by CCS and the new common raw sensor model. I can add that. > commit message ? > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > .../userspace-api/media/drivers/camera-sensor.rst | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/userspace-api/media/drivers/camera-sensor.rst b/Documentation/userspace-api/media/drivers/camera-sensor.rst > > index dc415b8f6c8e..d82cd803e337 100644 > > --- a/Documentation/userspace-api/media/drivers/camera-sensor.rst > > +++ b/Documentation/userspace-api/media/drivers/camera-sensor.rst > > @@ -111,13 +111,12 @@ the sensor configuration for the captured frame back to the host. While CSI-2 is > > the most common data interface used by such sensors, embedded data can be > > available on other interfaces as well. > > > > -Such sensors expose two internal sink pads (pads that have both the > > -``MEDIA_PAD_FL_SINK <MEDIA-PAD-FL-SINK>`` and ``MEDIA_PAD_FL_INTERNAL > > -<MEDIA-PAD-FL-INTERNAL>`` flags set) to model the source of the image and > > -embedded data streams. Both of these pads produces a single stream, and the > > -sub-device routes those streams to the external (source) pad. If the sub-device > > -driver supports disabling embedded data, this can be done by disabling the > > -embedded data route via the ``VIDIOC_SUBDEV_S_ROUTING`` IOCTL. > > +Embedded data support is indicated by an internal sink pad (pad that has both > > "is indicated by the presence of an" ? Sounds good. > > > +the ``MEDIA_PAD_FL_SINK <MEDIA-PAD-FL-SINK>`` and ``MEDIA_PAD_FL_INTERNAL > > +<MEDIA-PAD-FL-INTERNAL>`` flags set) with a metadata format to model the > > +embedded data stream. If the sub-device driver supports disabling embedded data, > > +this can be done by disabling the embedded data route via the > > +``VIDIOC_SUBDEV_S_ROUTING`` IOCTL. > > Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> Thanks! > > > > In general, changing the embedded data format from the driver-configured values > > is not supported. The height of the metadata is device-specific and the width -- Kind regards, Sakari Ailus
