On Thu, Nov 07, 2024 at 11:11:34PM +0100, Hans de Goede wrote: > The GMIN code has support for sensors using external regulators enabled > by GPIOS, rather then using regulators build into the PMIC. > > With the exception of the Trekstor ST70408-4 (1) tablet there are no known > devices which actually use external regulators for the sensors and the code > for this is using deprecated old style GPIO numbers support for which is > going away. > > Remove the GPIO driven regulator support so that the gmin code no longer > depends on deprecated GPIO APIs. > > 1) The GMIN support itself is also deprecated and all sensor drivers still > using it are being moved over to use ACPI + runtime-pm and the ST70408-4 > shipped with Android as factory OS and thus will have broken ACPI tables > for the sensors, so like other Android factory OS tablets it will need > a bespoke solution anyways. Definitely a good patch! Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko