Hi, On 7-Nov-24 12:42 PM, Mauro Carvalho Chehab wrote: > Em Thu, 7 Nov 2024 12:32:33 +0100 > Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> escreveu: > >> Em Mon, 23 Sep 2024 13:53:06 +0300 >> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> escreveu: >> >>> We have the respective SPDX identifiers that are already being applied >>> to the files in question. Remove the License information boilerplate. >>> >>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> >>> --- >>> >>> Here to fix one of the missed TODO item before moving from staging. >>> This depends on 20240923085652.3457117-1-andriy.shevchenko@xxxxxxxxxxxxxxx. >>> But can be applied before that (it's trivial to adjust). >>> >>> drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 10 ---------- >>> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 10 ---------- >>> .../media/atomisp/i2c/atomisp-libmsrlisthelper.c | 11 ----------- >>> drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 11 ----------- >>> drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 10 ---------- >>> drivers/staging/media/atomisp/i2c/gc2235.h | 13 ------------- >>> drivers/staging/media/atomisp/i2c/mt9m114.h | 11 ----------- >>> drivers/staging/media/atomisp/i2c/ov2722.h | 11 ----------- >>> drivers/staging/media/atomisp/include/hmm/hmm.h | 11 ----------- >> >> Hmm... there's no SPDX for hmm.h header. We need to ensure that all files >> have SPDX license before removing the boilerplate. >> >>> drivers/staging/media/atomisp/include/hmm/hmm_bo.h | 11 ----------- >>> .../staging/media/atomisp/include/hmm/hmm_common.h | 11 ----------- >> >> Same for the above and for other header files. > > Nevermind. I didn't show enough context while checking it. All files > have SPDX. Patch LGTM. That is good to hear. Note I've included this + a bunch of other atomisp patches in an atomisp pull-request for 6.13, see: https://lore.kernel.org/linux-media/51e5e1cf-8aff-44fc-b40c-a0074a770a69@xxxxxxxxxx/ (in case you have not seen that yet) Regards, Hans