On Wed, Nov 06, 2024 at 10:05:22AM +0000, Daniel Scally wrote: > Add the yaml binding for ARM's Mali-C55 Image Signal Processor. > > Acked-by: Nayden Kanchev <nayden.kanchev@xxxxxxx> > Co-developed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > Signed-off-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx> > --- > Changes in v8: > > - Added the video clock back in. Now that we have actual hardware it's > clear that it's necessary. > - Added reset lines > - Dropped R-bs These are trivial, so I wish you kept the review... but since you ask, then comment further I recommend using b4, so your cover letter changelog comes with nice links to previous versions. I scrolled through entire cover letter for this (for me that's almost the only point of cover letter) and could not find them. Anyway, just a remark. ... > + resets: > + items: > + - description: vclk domain reset > + - description: aclk domain reset > + - description: hclk domain reset > + > + reset-names: > + items: > + - const: vresetn drop "reset", it's redundant and rather come here with logical name. I wonder what "n" means as well. It's not a GPIO to be "inverted"... I wonder about reset domains for clocks as well... is this just gate clock misrepresented? Best regards, Krzysztof
