Hi Ricardo, On 30-Oct-24 2:03 PM, Ricardo Ribalda wrote: > Hi Hans (de Goede, but others are welcome as well :) ) > > Some notebooks have a button to disable the camera (not to be mistaken > with the mechanical cover). This is a standard GPIO linked to the > camera via the ACPI table. > > 4 years ago we added support for this button in UVC via the Privacy control. > This has two issues: > - If the camera has its own privacy control, it will be masked > - We need to power-up the camera to read the privacy control gpio. > > We tried to fix the power-up issues implementing "granular power > saving" but it has been more complicated than anticipated.... > > Last year, we proposed a patchset to implement the privacy gpio as a > subdevice https://lore.kernel.org/linux-media/20230111-uvc_privacy_subdev-v1-0-f859ac9a01e3@xxxxxxxxxxxx/ > > I think it is a pretty clean solution and makes sense to use a > subdevice for something that is a sub device of the camera :). > > Before moving forward, Laurent and I would like to hear your opinion. Moving the GPIO handling + privacy ctrl to a subdev which can be kept open without powering on the camera sounds like a good plan to me. I have taken a quick look at the implementation from last year: https://lore.kernel.org/linux-media/20230111-uvc_privacy_subdev-v1-0-f859ac9a01e3@xxxxxxxxxxxx/ and that looks fine to me. I am aware that you have posted a new version: https://patchwork.linuxtv.org/project/linux-media/list/?series=13893 but I have not looked at that version yet and I don't know if / when I will have time to help with reviewing that version. Regards, Hans
