Hi Jai On Tue, Oct 29, 2024 at 02:27:35PM +0530, Jai Luthra wrote: > From: David Plowman <david.plowman@xxxxxxxxxxxxxxx> > > The datasheet for this sensor documents the minimum vblanking as being > 32 lines. It does fix some problems with occasional black lines at the > bottom of images (tested on Raspberry Pi). > > Signed-off-by: David Plowman <david.plowman@xxxxxxxxxxxxxxx> > Signed-off-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx> Confirmed by the documentation of register 0x114a/0x114b Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> > --- > drivers/media/i2c/imx219.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index e78a80b2bb2e455c857390b188c128b28c224778..f98aad74fe584a18e2fe7126f92bf294762a54e3 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -74,7 +74,7 @@ > #define IMX219_REG_VTS CCI_REG16(0x0160) > #define IMX219_VTS_MAX 0xffff > > -#define IMX219_VBLANK_MIN 4 > +#define IMX219_VBLANK_MIN 32 > > /* HBLANK control - read only */ > #define IMX219_PPL_DEFAULT 3448 > > -- > 2.47.0 > >
