Re: [PATCH] media: vb2: fix confusing log message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 24, 2024 at 8:24 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>
> If the number of allocated buffers is less than q->min_queued_buffers,
> then a debug message was logged saying that it needs at least that
> many queued buffers. But the test is about allocated buffers.
>
> Update the message to say "allocated buffers".
>
> Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> ---
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index d064e0664851..26228614ddcc 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -2329,7 +2329,7 @@ int vb2_core_streamon(struct vb2_queue *q, unsigned int type)
>         }
>
>         if (q_num_bufs < q->min_queued_buffers) {
> -               dprintk(q, 1, "need at least %u queued buffers\n",
> +               dprintk(q, 1, "need at least %u allocated buffers\n",
>                         q->min_queued_buffers);
>                 return -EINVAL;
>         }

Acked-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>

Best,
Tomasz





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux