Hi Bingbu,
On Thu, Oct 24, 2024 at 03:24:39PM +0800, Bingbu Cao wrote:
> The ipu6_mmu_pgsize() could be removed as driver unload this to
> the PCI core driver DMA ops instead of handling in IPU6 driver.
This should be squashed to the third patch: an unused static function will
trigger a compiler warning.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@xxxxxxxxx>
> ---
> drivers/media/pci/intel/ipu6/ipu6-mmu.c | 28 ----------------------------
> 1 file changed, 28 deletions(-)
>
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-mmu.c b/drivers/media/pci/intel/ipu6/ipu6-mmu.c
> index d746e42918ae..2d9c6fbd5da2 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-mmu.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-mmu.c
> @@ -644,34 +644,6 @@ phys_addr_t ipu6_mmu_iova_to_phys(struct ipu6_mmu_info *mmu_info,
> return phy_addr;
> }
>
> -static size_t ipu6_mmu_pgsize(unsigned long pgsize_bitmap,
> - unsigned long addr_merge, size_t size)
> -{
> - unsigned int pgsize_idx;
> - size_t pgsize;
> -
> - /* Max page size that still fits into 'size' */
> - pgsize_idx = __fls(size);
> -
> - if (likely(addr_merge)) {
> - /* Max page size allowed by address */
> - unsigned int align_pgsize_idx = __ffs(addr_merge);
> -
> - pgsize_idx = min(pgsize_idx, align_pgsize_idx);
> - }
> -
> - pgsize = (1UL << (pgsize_idx + 1)) - 1;
> - pgsize &= pgsize_bitmap;
> -
> - WARN_ON(!pgsize);
> -
> - /* pick the biggest page */
> - pgsize_idx = __fls(pgsize);
> - pgsize = 1UL << pgsize_idx;
> -
> - return pgsize;
> -}
> -
> void ipu6_mmu_unmap(struct ipu6_mmu_info *mmu_info, unsigned long iova,
> size_t size)
> {
--
Kind regards,
Sakari Ailus
