Hi Mauro, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mauro-Carvalho-Chehab/media-v4l2-ctrls-api-fix-error-handling-for-v4l2_g_ctrl/20241018-181159 base: https://git.linuxtv.org/media_stage.git master patch link: https://lore.kernel.org/r/4d36ccf66f48a870c9bc0f7e9fda595505c4d342.1729230718.git.mchehab%2Bhuawei%40kernel.org patch subject: [PATCH v2 01/13] media: v4l2-ctrls-api: fix error handling for v4l2_g_ctrl() config: i386-randconfig-141-20241021 (https://download.01.org/0day-ci/archive/20241022/202410220105.oP6D4QD7-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202410220105.oP6D4QD7-lkp@xxxxxxxxx/ smatch warnings: drivers/media/v4l2-core/v4l2-ctrls-api.c:825 set_ctrl_lock() warn: inconsistent returns 'ctrl->handler->lock'. vim +825 drivers/media/v4l2-core/v4l2-ctrls-api.c 71c689dc2e732d4 Hans Verkuil 2021-04-27 812 static int set_ctrl_lock(struct v4l2_fh *fh, struct v4l2_ctrl *ctrl, 71c689dc2e732d4 Hans Verkuil 2021-04-27 813 struct v4l2_ext_control *c) 71c689dc2e732d4 Hans Verkuil 2021-04-27 814 { 71c689dc2e732d4 Hans Verkuil 2021-04-27 815 int ret; 71c689dc2e732d4 Hans Verkuil 2021-04-27 816 71c689dc2e732d4 Hans Verkuil 2021-04-27 817 v4l2_ctrl_lock(ctrl); 54c5e2c49a4358b Mauro Carvalho Chehab 2024-10-18 818 ret = user_to_new(c, ctrl); 54c5e2c49a4358b Mauro Carvalho Chehab 2024-10-18 819 if (ret) 54c5e2c49a4358b Mauro Carvalho Chehab 2024-10-18 820 return ret; v4l2_ctrl_unlock() before returning 71c689dc2e732d4 Hans Verkuil 2021-04-27 821 ret = set_ctrl(fh, ctrl, 0); 71c689dc2e732d4 Hans Verkuil 2021-04-27 822 if (!ret) 54c5e2c49a4358b Mauro Carvalho Chehab 2024-10-18 823 ret = cur_to_user(c, ctrl); 71c689dc2e732d4 Hans Verkuil 2021-04-27 824 v4l2_ctrl_unlock(ctrl); 71c689dc2e732d4 Hans Verkuil 2021-04-27 @825 return ret; 71c689dc2e732d4 Hans Verkuil 2021-04-27 826 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
