Hi Sakari, On Mon, Oct 21, 2024 at 07:26:41AM +0000, Sakari Ailus wrote: > Hi Laurent, Tommaso, > > On Sun, Oct 20, 2024 at 07:43:54PM +0300, Laurent Pinchart wrote: > > Hi Tommaso, > > > > Thank you for the patch. > > > > On Sun, Oct 20, 2024 at 06:35:32PM +0200, Tommaso Merciai wrote: > > > Controls can be exposed to userspace via a v4l-subdevX device, and > > > userspace has to be able to subscribe to control events so that it is > > > notified when the control changes value. > > > If a control handler is set for the subdev then set the HAS_EVENTS > > > flag automatically into v4l2_subdev_init_finalize() and use > > > v4l2_ctrl_subdev_subscribe_event() and v4l2_event_subdev_unsubscribe() > > > as default if subdev don't have .(un)subscribe control operations. > > > > I would add here > > > > This simplifies subdev drivers by avoiding the need to set the > > V4L2_SUBDEV_FL_HAS_EVENTS flag and plug the event handlers, and ensures > > consistency of the API exposed to userspace. > > > > And you can also add > > > > Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > > Signed-off-by: Tommaso Merciai <tomm.merciai@xxxxxxxxx> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Thanks! > > I've picked this to my tree. > > Please try to properly wrap the commit message the next time, most editors > can do that automatically. Mmm.. In theory I have this cfg for my vim: filetype plugin indent on syntax on set title set tabstop=8 set softtabstop=8 set shiftwidth=8 set noexpandtab set number set hidden Thanks & Regards, Tommaso > > -- > Sakari Ailus
