Il 16/10/24 13:38, Mohammed Anees ha scritto:
Since platform compatibility is already verified, the
additional else branch is unnecessary and will never
be executed. To fix, remove this else condition.
Well, actually, even the one before the allocation of cmd can be removed,
because compatibility is already checked by __get_config_offset().
Besides, __get_config_offset() has another occurrence of an unneeded
else branch, as it's checking platform twice.... so you can clean up
that one as well.
P.S.: "media: platform: mtk-mdp3: cmdq: Remove duplicated platforms checks"
Cheers,
Angelo
Signed-off-by: Mohammed Anees <pvmohammedanees2003@xxxxxxxxx>
---
drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
index ea2ea119dd2a..168beed4155a 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
@@ -624,14 +624,11 @@ static struct mdp_cmdq_cmd *mdp_cmdq_prepare(struct mdp_dev *mdp,
if (ret)
goto err_free_cmd;
- if (CFG_CHECK(MT8183, p_id)) {
+ if (CFG_CHECK(MT8183, p_id))
num_comp = CFG_GET(MT8183, param->config, num_components);
- } else if (CFG_CHECK(MT8195, p_id)) {
+ else if (CFG_CHECK(MT8195, p_id))
num_comp = CFG_GET(MT8195, param->config, num_components);
- } else {
- ret = -EINVAL;
- goto err_destroy_pkt;
- }
+
comps = kcalloc(num_comp, sizeof(*comps), GFP_KERNEL);
if (!comps) {
ret = -ENOMEM;
