Re: [PATCH 02/10] media: test-drivers: drop vb2_ops_wait_prepare/finish

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/14/24 09:06, Hans Verkuil wrote:
Since commit 88785982a19d ("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.

Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.

This simplifies the code and this is a step towards the goal of deleting
these callbacks.

Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>
---
  drivers/media/test-drivers/vicodec/vicodec-core.c  | 2 --
  drivers/media/test-drivers/vim2m.c                 | 2 --
  drivers/media/test-drivers/vimc/vimc-capture.c     | 6 ------
  drivers/media/test-drivers/visl/visl-video.c       | 2 --
  drivers/media/test-drivers/vivid/vivid-meta-cap.c  | 2 --
  drivers/media/test-drivers/vivid/vivid-meta-out.c  | 2 --
  drivers/media/test-drivers/vivid/vivid-sdr-cap.c   | 2 --
  drivers/media/test-drivers/vivid/vivid-touch-cap.c | 2 --
  drivers/media/test-drivers/vivid/vivid-vbi-cap.c   | 2 --
  drivers/media/test-drivers/vivid/vivid-vbi-out.c   | 2 --
  drivers/media/test-drivers/vivid/vivid-vid-cap.c   | 2 --
  drivers/media/test-drivers/vivid/vivid-vid-out.c   | 2 --
  12 files changed, 28 deletions(-)


For vimc driver:

Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux