Christoph, On 10/14/24 1:54 PM, Christoph Hellwig wrote: > On Mon, Oct 14, 2024 at 11:47:32AM +0800, bingbu.cao@xxxxxxxxx wrote: >> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.c >> @@ -139,7 +139,7 @@ void ipu6_dma_sync_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist, >> int i; >> >> for_each_sg(sglist, sg, nents, i) >> - clflush_cache_range(page_to_virt(sg_page(sg)), sg->length); >> + clflush_cache_range(sg_virt(sg), sg->length); > > Not new in this code, but what guarantees that this driver never sees > highmem? > > The hardware is only in Intel 64-bit SoCs. And it is likely the driver working with 64-bit kernel. I am not sure driver should handle highmem. Any suggestions? -- Best regards, Bingbu Cao
