On Thu, Oct 10, 2024 at 08:45:04AM +0000, Sakari Ailus wrote: > On Mon, Sep 09, 2024 at 06:56:03PM +0300, Laurent Pinchart wrote: > > On Mon, Sep 09, 2024 at 05:48:28PM +0200, Paul Elder wrote: > > > The current order of locking between the driver mutex and the v4l2 > > > subdev state lock causes a circuluar locking dependency when trying to > > > set up a link. Fix this. > > > > > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > This being said, I think we should deprecate the video-mux driver and > > implement a driver that uses the V4L2 subdev internal routing API > > instead of basing the routing configuration on link setup. Any opinion ? > > Sounds good to me. But do we need a new driver? The subdev client streams > capability flag should help here, just as it does on other drivers. Good point, we could switch the driver behaviour depending on client capabilities. I like this ! > I applied this one, with spelling fixed in the commit message. -- Regards, Laurent Pinchart