On Fri, Oct 04, 2024 at 05:46:43PM +0300, Tomi Valkeinen wrote: > Add error handling to ub913_hw_init() using a new helper function, > ub913_update_bits(). ... > + ret = ub913_update_bits(priv, UB913_REG_GENERAL_CFG, > + UB913_REG_GENERAL_CFG_PCLK_RISING, > + priv->pclk_polarity_rising ? > + UB913_REG_GENERAL_CFG_PCLK_RISING : > + 0); So, you can use regmap_set_bits() / regmap_clear_bits() instead of this ternary. It also gives one parameter less to the regmap calls. > + if (ret) > + return ret; -- With Best Regards, Andy Shevchenko
