* Andy Walls (awalls@xxxxxxxxxxxxxxxx) wrote: > On Sun, 2010-11-28 at 17:40 +0000, Dr. David Alan Gilbert wrote: > > Hi, > > Sparse pointed me at the following line in ivtv-fileops.c's ivtv_v4l2_write: > > > > ivtv_write_vbi(itv, (const struct v4l2_sliced_vbi_data *)user_buf, elems); > > > > Hi David, > > Let me know if this patch works for your sparse build and adequately > addresses the problem. Hi Andy, Yes that seems to fix it. The only other comment I have is that it would probably be better if ivtv_write_vbi_from_user() were to return an error if the copy_from_user were to fail and then pass that all the way back up so that if an app passed a bad pointer in it would get an EFAULT or the like. Thanks, Dave -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ gro.gilbert @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
