Em Mon, 30 Sep 2024 15:46:19 +0300 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu: > > >> Cocci has located some places where the helpers can be used. This > > >> patchset uses the diff generated by cocci, plus these changes: > > > > > > Personally I think most of those helpers just hinder readability for not > > > much added gain. String de-duplication is done by the linker already. > > > The only value I see in the helpers is ensuring that the strings are > > > consistently written, and I think we can do so through other means. > > > > Just my opinion: I'm OK with these new helpers, > > Coding style opinions are personal preferences of course :-) My opinion > is that this hinders readability for no benefit. Agreed. New code somewhat obfuscates what it does with no benefit except maybe saving a few bytes on each drive. Thanks, Mauro
