Hi Laurent, Thank you for the review. On Sat, Sep 28, 2024 at 12:11 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > I've just noticed that the subject line of most of your patches is much > longer than the 72 characters limit. Please try to shorten them. You can > replace the prefixes with "media: rzg2l-cru:", and reword the subject > lines that mention long function names. > Ok, I'll rework the subject line so that it fits within 72 characters. > On Tue, Sep 10, 2024 at 06:53:55PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Make use `rzg2l_csi2_formats` array in rzg2l_csi2_enum_frame_size(). > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > index 79d99d865c1f..e630283dd1f1 100644 > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c > > @@ -570,7 +570,10 @@ static int rzg2l_csi2_enum_frame_size(struct v4l2_subdev *sd, > > struct v4l2_subdev_state *sd_state, > > struct v4l2_subdev_frame_size_enum *fse) > > { > > - if (fse->index != 0) > > + if (fse->index >= ARRAY_SIZE(rzg2l_csi2_formats)) > > + return -EINVAL; > > Same comment as in 11/16. With this fixed, > Ok, I'll drop this check. > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > Cheers, Prabhakar