Ozan ÃaÄlayan <ozan@xxxxxxxxxxxxx> writes: > Pazartesi 18 Ekim 2010 gÃnà (saat 00:20:31) Mauro Carvalho Chehab ÅunlarÄ > yazmÄÅtÄ: >> Hi, > >> Jun,21 2010: Mantis, hopper: use MODULE_DEVICE_TABLE use the macro to make > modules http://patchwork.kernel.org/patch/107147 Manu > > This was first spotted by me in February 2010 in this list. Then several > people in this list spotted that the modules were missing MODULE_DEVICE_TABLE. > Well I thought that it should already be merged during the last 10 months but > I'm surprised to see that it's not. > > Note that without this patch those drivers are not automatically loaded by > udev so all other efforts of improving the mantis stuff stays insignificant > for end-users. well, the excellent Debian kernel team actually accepted this patch when adding the backported mantis driver to their 2.6.32 kernel, so at least Debian end users do get auto loading: bjorn@nemi:~$ modinfo mantis filename: /lib/modules/2.6.32-5-amd64/kernel/drivers/media/dvb/mantis/mantis.ko license: GPL author: Manu Abraham description: MANTIS driver alias: pci:v00001822d00004E35sv00001822sd00000024bc*sc*i* alias: pci:v00001822d00004E35sv0000153Bsd00001178bc*sc*i* alias: pci:v00001822d00004E35sv00001AE4sd00000002bc*sc*i* alias: pci:v00001822d00004E35sv00001822sd00000043bc*sc*i* alias: pci:v00001822d00004E35sv00001822sd00000008bc*sc*i* alias: pci:v00001822d00004E35sv0000153Bsd00001179bc*sc*i* alias: pci:v00001822d00004E35sv00001AE4sd00000003bc*sc*i* alias: pci:v00001822d00004E35sv00001AE4sd00000001bc*sc*i* alias: pci:v00001822d00004E35sv00001822sd00000031bc*sc*i* alias: pci:v00001822d00004E35sv00001822sd00000014bc*sc*i* alias: pci:v00001822d00004E35sv00001822sd00000016bc*sc*i* depends: mantis_core,stv0299,i2c-core,stb0899,zl10353,tda10023,tda10021,stb6100,mb86a16,lnbp21,tda665x vermagic: 2.6.32-5-amd64 SMP mod_unload modversions parm: verbose:verbose startup messages, default is 1 (yes) (int) bjorn@nemi:~$ dpkg -S /lib/modules/2.6.32-5-amd64/kernel/drivers/media/dvb/mantis/mantis.ko linux-image-2.6.32-5-amd64: /lib/modules/2.6.32-5-amd64/kernel/drivers/media/dvb/mantis/mantis.ko bjorn@nemi:~$ apt-cache policy linux-image-2.6.32-5-amd64 linux-image-2.6.32-5-amd64: Installed: 2.6.32-28 Candidate: 2.6.32-28 Version table: *** 2.6.32-28 0 990 http://ftp.no.debian.org/debian/ squeeze/main amd64 Packages 600 http://ftp.no.debian.org/debian/ sid/main amd64 Packages 100 /var/lib/dpkg/status (Note that the extensive "depends" shows that it's still missing one of the other critical patches....) > Can this be fixed ASAP? At least it's now queued for 2.6.38: bjorn@canardo:/usr/local/src/git/linux-2.6$ git shortlog origin..media_tree/staging/for_v2.6.38 drivers/media/dvb/mantis/ Ben Hutchings (1): [media] Mantis: Rename gpio_set_bits to mantis_gpio_set_bits BjÃrn Mork (1): [media] Mantis: use dvb_attach to avoid double dereferencing on module removal David HÃÂrdeman (1): [media] ir-core: make struct rc_dev the primary interface Manu Abraham (1): [media] Mantis, hopper: use MODULE_DEVICE_TABLE Marko Ristola (1): [media] Mantis: append tasklet maintenance for DVB stream delivery Mauro Carvalho Chehab (4): [media] rc: rename the remaining things to rc_core [media] rc: Rename remote controller type to rc_type instead of ir_type [media] rc: Name RC keymap tables as rc_map_table [media] rc: use rc_map_ prefix for all rc map tables And I will submit it to stable as soon as it's in Linus' tree, unless someone beats me to it... BjÃrn -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
