Hi Laurent, On Sat, Sep 28, 2024 at 12:27 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > On Fri, Sep 27, 2024 at 12:51:24PM +0000, Prabhakar Mahadev Lad wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > > > > From: Daniel Scally <dan.scally+renesas@xxxxxxxxxxxxxxxx> > > > > > > Rather than open-code a calculation of the format's bytesperline and > > > sizeimage, use the v4l2_fill_pixfmt() helper. This makes it easier to > > > support the CRU packed pixel formats without over complicating the driver. > > > > > > This change makes the .bpp member of struct rzg2l_cru_ip_format and the > > > rzg2l_cru_ip_pix_fmt_to_bpp() function superfluous - remove them both. > > > > > > Signed-off-by: Daniel Scally <dan.scally+renesas@xxxxxxxxxxxxxxxx> > > > --- > > > .../platform/renesas/rzg2l-cru/rzg2l-cru.h | 3 --- > > > .../platform/renesas/rzg2l-cru/rzg2l-ip.c | 16 -------------- > > > .../platform/renesas/rzg2l-cru/rzg2l-video.c | 21 ++----------------- > > > 3 files changed, 2 insertions(+), 38 deletions(-) > > > > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > This patch doesn't apply cleanly on top of media-stage + [0] > > > > [0] https://lore.kernel.org/all/20240910175357.229075-1-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/ > > Is it fine with you to wait for v3 of your series and rebase this one on > top ? > Yep, sounds good to me. Cheers, Prabhakar
