Hi Prabhakar, Thank you for the patch. On Tue, Sep 10, 2024 at 06:53:42PM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Use enum values (`RZG2L_CRU_IP_SINK` and `RZG2L_CRU_IP_SOURCE`) instead > of hardcoded array indices. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c > index ac8ebae4ed07..9f0ea1de50da 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c > @@ -217,8 +217,8 @@ int rzg2l_cru_ip_subdev_register(struct rzg2l_cru_dev *cru) > ip->subdev.entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER; > ip->subdev.entity.ops = &rzg2l_cru_ip_entity_ops; > > - ip->pads[0].flags = MEDIA_PAD_FL_SINK; > - ip->pads[1].flags = MEDIA_PAD_FL_SOURCE; > + ip->pads[RZG2L_CRU_IP_SINK].flags = MEDIA_PAD_FL_SINK; > + ip->pads[RZG2L_CRU_IP_SOURCE].flags = MEDIA_PAD_FL_SOURCE; > > ret = media_entity_pads_init(&ip->subdev.entity, 2, ip->pads); > if (ret) -- Regards, Laurent Pinchart
