Hi Andy On Fri, 27 Sept 2024 at 12:10, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Fri, Sep 27, 2024 at 1:02 PM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote: > > > > The str_up_down() helper simplifies the code and fixes the following cocci > > warning: > > > > drivers/media/platform/ti/cal/cal-camerarx.c:194:3-9: opportunity for str_up_down(enable) > > ... > > > if (i == 10) > > phy_err(phy, "Failed to power %s complexio\n", > > - enable ? "up" : "down"); > > + str_up_down(enable); > > You never tested this, do not bother to send untested material, please! Do you mean tested in real hardware or compile test it? I did test it: https://gitlab.freedesktop.org/linux-media/users/ribalda/-/commits/test-newlinus But obviously we are not building that file :S. Let me figure out why did this happened Sorry for the noise > > -- > With Best Regards, > Andy Shevchenko -- Ricardo Ribalda
