On 12/09/2010 10:39 AM, Dmitry Torokhov wrote: > The desire to keep old names for the EVIOCGKEYCODE/EVIOCSKEYCODE while > extending them to support large scancodes was a mistake. While we tried > to keep ABI intact (and we succeeded in doing that, programs compiled > on older kernels will work on newer ones) there is still a problem with > recompiling existing software with newer kernel headers. > > New kernel headers will supply updated ioctl numbers and kernel will > expect that userspace will use struct input_keymap_entry to set and > retrieve keymap data. But since the names of ioctls are still the same > userspace will happily compile even if not adjusted to make use of the > new structure and will start miraculously fail in the field. > > To avoid this issue let's revert EVIOCGKEYCODE/EVIOCSKEYCODE definitions > and add EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2 so that userspace can explicitly > select the style of ioctls it wants to employ. > > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> > --- Would the header change suffice in itself? Either way, also checked that the bugfixes following the original patch is still in effect, so looks ok to me. Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
