Moi,
On Tue, Sep 17, 2024 at 05:22:29PM +0300, Tomi Valkeinen wrote:
> On 17/09/2024 15:43, Sakari Ailus wrote:
> > The scope of the s_stream video operation is now fully supported by
> > {enable,disable}_straems. Explicitly document the s_stream() op as
> > deprecated and update the related documentation.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> > Documentation/driver-api/media/camera-sensor.rst | 8 ++++----
> > Documentation/driver-api/media/tx-rx.rst | 11 ++++++-----
> > include/media/v4l2-subdev.h | 5 +++--
> > 3 files changed, 13 insertions(+), 11 deletions(-)
> >
> > diff --git a/Documentation/driver-api/media/camera-sensor.rst b/Documentation/driver-api/media/camera-sensor.rst
> > index b4920b34cebc..c290833165e6 100644
> > --- a/Documentation/driver-api/media/camera-sensor.rst
> > +++ b/Documentation/driver-api/media/camera-sensor.rst
> > @@ -81,10 +81,10 @@ restart when the system is resumed. This requires coordination between the
> > camera sensor and the rest of the camera pipeline. Bridge drivers are
> > responsible for this coordination, and instruct camera sensors to stop and
> > restart streaming by calling the appropriate subdev operations
> > -(``.s_stream()``, ``.enable_streams()`` or ``.disable_streams()``). Camera
> > -sensor drivers shall therefore **not** keep track of the streaming state to
> > -stop streaming in the PM suspend handler and restart it in the resume handler.
> > -Drivers should in general not implement the system PM handlers.
> > +(``.enable_streams()`` or ``.disable_streams()``). Camera sensor drivers shall
>
> I didn't go through the docs, but I think we need to make it clear somewhere
> that v4l2_subdev_enable_streams() and v4l2_subdev_disable_streams() _must_
> be used to enable/disable the streaming in the source subdevice, and the
> related subdev callbacks must not be called directly.
It was in the header but not in tx-rx.rst. I added it there for v2.
>
> Also, v4l2_subdev_enable_streams() and v4l2_subdev_disable_streams() kernel
> doc doesn't seem to clarify that if the driver using those functions does
> not support streams, it should use BIT_ULL(1) as the streams_mask parameter.
BIT_ULL(0)?
I'll add that, too.
--
Terveisin,
Sakari Ailus
