Re: [PATCH] media: dw100: Rectify debug log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Umang,

On 9/14/24 4:40 PM, Kieran Bingham wrote:
Quoting Umang Jain (2024-09-14 15:29:28)
Rectify dev_dbg() log of dw100_hw_set_destination() from
"Set HW source registers" to "Set HW destination registers".


Yes, that looks pretty clear to be a copy/paste error when the function
was duplicated, and would make reading the logs confusing.

Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>

Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
---
  drivers/media/platform/nxp/dw100/dw100.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
index 0024d6175ad9..394f1f6129e3 100644
--- a/drivers/media/platform/nxp/dw100/dw100.c
+++ b/drivers/media/platform/nxp/dw100/dw100.c
@@ -1311,7 +1311,7 @@ static void dw100_hw_set_destination(struct dw100_device *dw_dev,
         }
dev_dbg(&dw_dev->pdev->dev,
-               "Set HW source registers for %ux%u - stride %u, pixfmt: %p4cc, dma:%pad\n",
+               "Set HW destination registers for %ux%u - stride %u, pixfmt: %p4cc, dma:%pad\n",
                 width, height, stride, &fourcc, &addr_y);
/* Pixel Format */
--
2.45.2

Thanks for your patch. Indeed..

Reviewed-by: Xavier Roumegue <xavier.roumegue@xxxxxxxxxxx>





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux