On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay <devnull+git.apitzsch.eu@xxxxxxxxxx> wrote: > > From: André Apitzsch <git@xxxxxxxxxxx> > > The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value > in the mode_<res> registers arrays, and once via v4l2_ctrl_ops. The > latter is enough, drop the former. > > Signed-off-by: André Apitzsch <git@xxxxxxxxxxx> Acked-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > --- > drivers/media/i2c/imx214.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c > index 91664e188fd0..4507e12dd4cd 100644 > --- a/drivers/media/i2c/imx214.c > +++ b/drivers/media/i2c/imx214.c > @@ -254,7 +254,6 @@ static const struct cci_reg_sequence mode_4096x2304[] = { > { CCI_REG8(0x3011), 0x00 }, > { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON }, > > - { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT }, > { IMX214_REG_SHORT_EXPOSURE, 500 }, > > { IMX214_REG_ANALOG_GAIN, 0 }, > @@ -328,7 +327,6 @@ static const struct cci_reg_sequence mode_1920x1080[] = { > { CCI_REG8(0x3011), 0x00 }, > { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON }, > > - { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT }, > { IMX214_REG_SHORT_EXPOSURE, 500 }, > > { IMX214_REG_ANALOG_GAIN, 0 }, > > -- > 2.46.0 > >