Hi Tommaso, On Tue, Sep 10, 2024 at 03:44:27PM +0200, Tommaso Merciai wrote: > Controls can be exposed to userspace via a v4l-subdevX device, and > userspace has to be able to subscribe to control events so that it is > notified when the control changes value. Add missing HAS_EVENTS flag. How is this supposed to work, given that the driver doesn't implement .subscribe_event() ? > Signed-off-by: Tommaso Merciai <tomm.merciai@xxxxxxxxx> > --- > drivers/media/i2c/max96714.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/max96714.c b/drivers/media/i2c/max96714.c > index 159753b13777..94b1bc000e48 100644 > --- a/drivers/media/i2c/max96714.c > +++ b/drivers/media/i2c/max96714.c > @@ -602,7 +602,8 @@ static int max96714_create_subdev(struct max96714_priv *priv) > goto err_free_ctrl; > } > > - priv->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_STREAMS; > + priv->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | > + V4L2_SUBDEV_FL_HAS_EVENTS | V4L2_SUBDEV_FL_STREAMS; > priv->sd.entity.function = MEDIA_ENT_F_VID_IF_BRIDGE; > priv->sd.entity.ops = &max96714_entity_ops; > -- Regards, Laurent Pinchart
