Hi Depeng, I do have one more ask for a change. On 8/12/24 17:41, Depeng Shao wrote:
Add bindings for qcom,sm8550-camss in order to support the camera subsystem for sm8550. Co-developed-by: Yongsheng Li <quic_yon@xxxxxxxxxxx> Signed-off-by: Yongsheng Li <quic_yon@xxxxxxxxxxx> Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
<snip>
+ + vdda-phy-supply: + description: + Phandle to a regulator supply to PHY core block. + + vdda-pll-supply: + description: + Phandle to 1.2V regulator supply to PHY refclk pll block. +
Here the supplies should be split into ones, which are specific to CSI blocks, and I believe they shall be set as optional. The proposed names are: vdda-phy-01-supply vdda-pll-01-supply vdda-phy-23-supply vdda-pll-23-supply vdda-phy-46-supply vdda-pll-46-supply vdda-phy-57-supply vdda-pll-57-supply I understand that what I ask is much more clumsy, and it could be seen even as unneeded, however it'll be the right set of properties to describe the CAMSS IP in this respect. -- Best wishes, Vladimir
