Re: [PATCH] libv4l: Add support for 8-bits grey format (V4L2_PIX_FMT_GREY)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em 08-12-2010 13:00, Hans de Goede escreveu:
> Hi,
> 

>> +    /* Clear U/V */
>> +    memset(dest, 0, src_fmt->fmt.pix.width * src_fmt->fmt.pix.height / 2);
> 
> This is wrong the "0" value for U/V is 0x80 (U and V are signed, but not two's
> complement instead their range is up shifted by 0x80)
> 
> Otherwise the patch looks good.

True. Yeah, a silly mistake. Ok, I fixed it and added the patch at v4l-utils.

Thanks for the review!
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux