Hello, On Wednesday, December 08, 2010 8:02 AM Sewoon Park wrote: > Hello~ > There are a lot of code changes compared with version5 patch. > Some minor comments below. Thanks for spotting old, outdated comments. I'm sorry that I forgot about them. I will update them asap. > <snip> > You mentioned that dma-sg and iommu allocators will definitely call get_user_pages(). > There are dms-sg allocator in v6 patch. How to apply it? Please take a look at drivers/media/video/videobuf2-dma-sg.c and include/media/videobuf2-dma-sg.h In the header file there is a vb2_dma_sg_desc structure define. It should be used as the main interface between the allocator and the driver. A pointer to this structure is returned by vb2_dma_sg_plane_desc() inline function (which in turn calls plane_cookie()). This structure contains all the information that might be required to setup scatter-gather or iommu controller: the size of the memory region, number of pages and the array of the pages (see sglist entry and scatterlist structure). This dma-sg allocator supports both mmap and userptr access modes. If there is anything missing please let us know. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
