Re: [PATCH 4/9] media: platform: Add c3 mipi adapter driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

        Thanks for your reply.

On 2024/9/3 22:12, Krzysztof Kozlowski wrote:
[You don't often get email from krzk@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

[ EXTERNAL EMAIL ]

On 03/09/2024 08:57, Keke Li via B4 Relay wrote:
From: Keke Li <keke.li@xxxxxxxxxxx>

This driver mainly responsible for organizing
MIPI data and sending raw data to ISP pipeline.

Signed-off-by: Keke Li <keke.li@xxxxxxxxxxx>
...

+static int c3_mipi_adap_probe(struct platform_device *pdev)
+{
+     struct device *dev = &pdev->dev;
+     struct adap_device *adap;
+     int ret;
+
+     adap = devm_kzalloc(dev, sizeof(*adap), GFP_KERNEL);
+     if (!adap)
+             return -ENOMEM;
+
+     adap->info = of_device_get_match_data(dev);
+     adap->dev = dev;
+
+     ret = c3_mipi_adap_ioremap_resource(adap);
+     if (ret) {
+             dev_err(dev, "Failed to ioremap resource: %d\n", ret);
+             return ret;
+     }
+
+     ret = c3_mipi_adap_configure_clocks(adap);
+     if (ret) {
+             dev_err(dev, "Failed to configure clocks: %d\n", ret);
All your patches repeat the same patterns, so all my comments apply to
each patch.

OK,  I will modify the code according to your comments.

Thanks again.


Best regards,
Krzysztof





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux