Re: [PATCH 2/9] media: platform: Add c3 mipi csi2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

       Thanks for your reply.

On 2024/9/3 22:10, Krzysztof Kozlowski wrote:
[You don't often get email from krzk@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

[ EXTERNAL EMAIL ]

On 03/09/2024 08:57, Keke Li via B4 Relay wrote:
From: Keke Li <keke.li@xxxxxxxxxxx>

This driver is used to receive mipi data from image sensor.

Signed-off-by: Keke Li <keke.li@xxxxxxxxxxx>

...

+static int c3_mipi_csi_probe(struct platform_device *pdev)
+{
+     struct device *dev = &pdev->dev;
+     struct csi_device *csi;
+     int ret;
+
+     csi = devm_kzalloc(dev, sizeof(*csi), GFP_KERNEL);
+     if (!csi)
+             return -ENOMEM;
+
+     csi->info = of_device_get_match_data(dev);
+     csi->dev = dev;
+
+     ret = c3_mipi_csi_ioremap_resource(csi);
+     if (ret) {
+             dev_err(dev, "Failed to ioremap resource: %d\n", ret);
+             return ret;
+     }
+
+     ret = c3_mipi_csi_configure_clocks(csi);
+     if (ret) {
+             dev_err(dev, "Failed to configure clocks: %d\n", ret);
+             return ret;
Syntax is return dev_err_probe. This was repeated multiple times, so
please organize some inside-Amlogic sessions so you will learn from
somebody's mistakes/reviews. That's way other developers do not repeat
the same issue.

Will use dev_err_probe.

I will report this issue to my manager and learn from experiences of others.


Best regards,
Krzysztof





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux