Hi, On 9/3/24 12:30 PM, Andy Shevchenko wrote: > On Tue, Sep 3, 2024 at 12:27 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> On 9/2/24 2:03 PM, Andy Shevchenko wrote: >>> On Mon, Sep 02, 2024 at 11:52:29AM +0200, Hans de Goede wrote: > > ... > >>>> -static int __ia_css_binary_find(struct ia_css_binary_descr *descr, >>>> - struct ia_css_binary *binary) { >>>> +int ia_css_binary_find(struct ia_css_binary_descr *descr, >>>> + struct ia_css_binary *binary) >>> >>> ...for example, in this case you touched both lines, so making them a single >>> line just reduces the future churn. >> >> Ack, fixed in my media-atomisp branch. > > (Actually there are more opportunities like this that I haven't > commented on in the previous reply. I hope you have already found them > and fixed accordingly) Yes I've gone over the entire patch and made lines longer to avoid needing multiple lines where possible. Regards, Hans