Without these ops the v4l2-compliance blocking wait test will fail. These ops are required to ensure that when VIDIOC_DQBUF has to wait for buffers to arrive, the queue lock is correctly released and retaken. Otherwise the wait for a buffer would block all other queue ioctls. I would appreciate it if these patches can be tested. I also updated v4l2-compliance so that it executes the blocking wait test even if the '-s' option was not specified. This should improve coverage since not everyone uses that option. After this series is (hopefully) applied I plan to make changes to avoid the need to set these two ops, unless you need a custom implementation (omap3isp). Regards, Hans Hans Verkuil (4): media: atomisp: add missing wait_prepare/finish ops media: omap3isp: add missing wait_prepare/finish ops media: pisp_be: add missing wait_prepare/finish ops media: venus: add missing wait_prepare/finish ops drivers/media/platform/qcom/venus/vdec.c | 2 ++ drivers/media/platform/qcom/venus/venc.c | 2 ++ .../platform/raspberrypi/pisp_be/pisp_be.c | 2 ++ drivers/media/platform/ti/omap3isp/ispvideo.c | 18 ++++++++++++++++++ .../staging/media/atomisp/pci/atomisp_fops.c | 2 ++ 5 files changed, 26 insertions(+) -- 2.43.0
