Hi Laurent
On Sat, Aug 31, 2024 at 04:03:30AM GMT, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Aug 27, 2024 at 09:40:15AM +0200, Jacopo Mondi wrote:
> > A comment in the pisp_be driver references to the
>
> s/to the/the/
>
> > pispbe_schedule_internal() which doesn't exist.
>
> s/which/function which/
>
> >
> > Drop it.
> >
> > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> > index 65ff2382cffe..8ba1b9f43ba1 100644
> > --- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> > +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> > @@ -368,10 +368,7 @@ static void pispbe_xlate_addrs(struct pispbe_dev *pispbe,
> > ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE],
> > &pispbe->node[MAIN_INPUT_NODE]);
> > if (ret <= 0) {
> > - /*
> > - * This shouldn't happen; pispbe_schedule_internal should insist
> > - * on an input.
> > - */
> > + /* Shouldn't happen, we have validated an input is available. */
>
> Actually, where is that validated ?
>
When preparing a job, the MAIN_INPUT_NODE buffer is mandatory if I
read the usage of the 'ignore_buffers' flag right ?
> > dev_warn(pispbe->dev, "ISP-BE missing input\n");
> > hw_en->bayer_enables = 0;
> > hw_en->rgb_enables = 0;
>
> --
> Regards,
>
> Laurent Pinchart
