Hi Niklas Söderlund, Thanks for the patch. > -----Original Message----- > From: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > Sent: Monday, August 26, 2024 3:44 PM > Subject: [PATCH v2 4/6] media: rcar-isp: Add family compatible for R-Car Gen4 family > > Add the Gen4 family compatible. This will be used instead of a SoC specific compatible for the new > Gen4 SoC V4M. Two Gen4 boards (V3U and > V4H) have already been added prior and their bindings need to be kept for backward compatibility. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > * Changes since v1 > - Reworked to add a family compatible instead of V4M specific one. > --- > drivers/media/platform/renesas/rcar-isp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/renesas/rcar-isp.c b/drivers/media/platform/renesas/rcar-isp.c > index 4512ac338ca5..6504c7025a40 100644 > --- a/drivers/media/platform/renesas/rcar-isp.c > +++ b/drivers/media/platform/renesas/rcar-isp.c > @@ -429,8 +429,11 @@ static int risp_probe_resources(struct rcar_isp *isp, } > > static const struct of_device_id risp_of_id_table[] = { > + /* Keep to be compatible with old DTS files. */ > { .compatible = "renesas,r8a779a0-isp" }, > + /* Keep to be compatible with old DTS files. */ > { .compatible = "renesas,r8a779g0-isp" }, > + { .compatible = "renesas,rcar-gen4-isp" }, > { /* sentinel */ }, Nit pick: Comma can be dropped from last entry. Cheers, Biju > }; > MODULE_DEVICE_TABLE(of, risp_of_id_table); > -- > 2.45.2 >