Hello, Devin, 2010/12/5 Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx>: > On Sun, Dec 5, 2010 at 12:09 PM, Alexey Chernov <4ernov@xxxxxxxxx> wrote: >> Hello, Steve, >> thank you very much for your comments! >> >> As for DVB maybe I'm not correct. The initialization itself, which the DVB >> part of patch is about, is fully tested by me and works successfully on my >> everyday PC. The thing I meant saying 'untested' concerned receiving DVB >> signal through the initialized device. >> >> So I think I was mistaken that the code itself is untested. I hope it's >> possible to add full of this patch. > > Hello Alexey, > > What I believe Steven is trying to say is the device successfully > initializing is not enough to consider the DVB part of the driver to > be "working". ÂIf you have not seen the device receiving digital > television, the DVB parts of this patch should not be committed. > There are a variety of other reasons why DVB streaming would not work > even if the device properly initializes. ÂThese can include an > improperly configured IF, wrong GPIOs, missing power management code, > etc. > > It is far worse for a user to be led to believe the driver should be > working but doesn't then it is for the driver claim to not work with > DVB at all. ÂThis is how we end up with users wasting hours wondering > what is wrong with their MythTV setup when in fact the driver never > actually worked in the first place. Thank you for additional description. I agree with you that successful DVB initialization and my tests doesn't necessarily guarantee its full proper work. But I can't see any reasons why the code can't be included. I think not including this code harms far more. I see a lot of people using binary distros on Gotview forum at least which would like to test Linux drivers for their cards. They could test them in wide variety of different circumstances. But they are normal users and they don't want even to hear about any patches and kernel builds. If DVB works in their distro's kernel maybe someone would test it on real signal. If it is not even initialized, nobody would test it. Not even saying about big efforts which took me this DVB part of patch (I should say, most part of the time spent on this patch). > Find someone to test the DVB parts of the board that it shows DVB > streaming. ÂIf you cannot do that, remove those parts from the patch > until someone can be found who is able to test the functionality. Surely I tried to find someone to test the DVB parts but DVB-T is not spread so wide here in Russia where Gotview cards seem to be primarily sold and I wasn't able to find anybody. Gotview support team was also unable to help me with this problem. So, is it impossible now to accept the patch in its current state? > Devin > > -- > Devin J. Heitmueller - Kernel Labs > http://www.kernellabs.com > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
