On Mon, Aug 19, 2024 at 06:24:56PM +0200, Mauro Carvalho Chehab wrote:
> Basically, the actual SMS device type is given by this enum:
>
> enum sms_device_type_st {
> SMS_UNKNOWN_TYPE = -1,
>
> SMS_STELLAR = 0,
> SMS_NOVA_A0,
> SMS_NOVA_B0,
> SMS_VEGA,
> SMS_VENICE,
> SMS_MING,
> SMS_PELE,
> SMS_RIO,
> SMS_DENVER_1530,
> SMS_DENVER_2160,
>
> SMS_NUM_OF_DEVICE_TYPES /* This is just a count */
> };
>
> But I dunno if there are a 1:1 mapping between type and chipset
> number. The above type names probably match some vendor internal
> names, but we never had any tables associating them to a device number,
> as the vendor never provided us such information.
>
> Btw I vaguely remember I heard about a newer Siano chipsets (sm3xxx),
> but never saw such devices.
>
> -
>
> Now, I'm not sure about what endpoints this specific driver exports, as
> I'm lacking vendor's documentation. What I said is that almost all DVB
> devices have isoc endpoints, but I dunno if this is the case of Siano.
Currently the driver exports only bulk endpoints, even though it doesn't
check the endpoint type. You can tell because the only routine in it
that calls usb_submit_urb() is smsusb_submit_urb(), and that routine
calls usb_fill_bulk_urb() before doing the submission.
Given this, I suggest merging the earlier patch submission from Nikita
Zhandarovich as-is. If the driver ever evolves to include support for
isochronous endpoints, the probe function can be modified then.
Alan Stern
