Re: [PATCH 12/13] media: qcom: camss: Add CSID Gen3 support for sm8550

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bryan,

On 8/16/2024 7:34 PM, Bryan O'Donoghue wrote:

Just noticed this too.

You're configuring the CSID routing here for each enabled VC but, you should only do that once @ the top level

->


     __csid_configure_top(csid);

     /* Loop through all enabled VCs and configure stream for each */
     for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS; i++)
         if (csid->phy.en_vc & BIT(i)) {
             __csid_configure_rdi_stream(csid, enable, i);
             __csid_configure_rx(csid, &csid->phy, i);
             __csid_ctrl_rdi(csid, enable, i);
         }


Yes, you are right, will move configure_top out of the for loop.

Thanks,
Depeng





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux