On Fri, Aug 09, 2024 at 02:47:53PM +0800, Keguang Zhang wrote: > On Thu, Aug 8, 2024 at 11:37 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > On Thu, Aug 08, 2024 at 07:22:19PM +0800, Keguang Zhang via B4 Relay wrote: > > > From: Keguang Zhang <keguang.zhang@xxxxxxxxx> > > > > > > Add devicetree binding document for Loongson-1 NAND Controller. > > > > > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx> > > > --- > > > Changes in v8: > > > - Add a description part. > > > - Adjust the compatible because the match data for ls1c-nfc differs from ls1b-nfc. > > > - Mark 'nand-use-soft-ecc-engine' and 'nand-ecc-algo' as mandatory. > > > - Delete the superfluous blank lines. > > > > > > Changes in v7: > > > - rename the file to loongson,ls1b-nfc.yaml > > > > > > Changes in v6: > > > - A newly added patch > > > --- > > > .../devicetree/bindings/mtd/loongson,ls1b-nfc.yaml | 75 ++++++++++++++++++++++ > > > 1 file changed, 75 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/loongson,ls1b-nfc.yaml b/Documentation/devicetree/bindings/mtd/loongson,ls1b-nfc.yaml > > > new file mode 100644 > > > index 000000000000..7ce335324a29 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mtd/loongson,ls1b-nfc.yaml > > > > When I first read "nfc" here I thought it was a copy-paste mistake, as > > "nfc" is a technology of it's own. I think it would make sense to rename > > to "loongson,ls1b-nand-controller" etc to remove that sort of confusion. > > These devices might not implement NFC, but what's to say that a future > > device will not? > > > Sorry for the confusion. > The string "loongson,ls1b-nand-controller" might be too long. It "might"? Why do you think it is too long? > May I rename it to "loongson,ls1b-nand"? Sure.
Attachment:
signature.asc
Description: PGP signature
