Re: [PATCH 6.10 288/809] media: dvb-usb: Fix unexpected infinite loop in dvb_usb_read_remote_control()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/08/2024 08:57, Greg Kroah-Hartman wrote:
> On Thu, Aug 01, 2024 at 07:21:25PM +0200, Stefan Lippers-Hollmann wrote:
>> Hi
>>
>> On 2024-08-01, Stefan Lippers-Hollmann wrote:
>>> On 2024-08-01, Stefan Lippers-Hollmann wrote:
>>>> On 2024-07-30, Greg Kroah-Hartman wrote:
>>>>> 6.10-stable review patch.  If anyone has any objections, please let me know.
>>>>>
>>>>> ------------------
>>>>>
>>>>> From: Zheng Yejian <zhengyejian1@xxxxxxxxxx>
>>>>>
>>>>> [ Upstream commit 2052138b7da52ad5ccaf74f736d00f39a1c9198c ]
>>>>>
>>>>> Infinite log printing occurs during fuzz test:
>>>>>
>>>>>   rc rc1: DViCO FusionHDTV DVB-T USB (LGZ201) as ...
>>>>>   ...
>>>>>   dvb-usb: schedule remote query interval to 100 msecs.
>>>>>   dvb-usb: DViCO FusionHDTV DVB-T USB (LGZ201) successfully initialized ...
>>>>>   dvb-usb: bulk message failed: -22 (1/0)
>>>>>   dvb-usb: bulk message failed: -22 (1/0)
>>>>>   dvb-usb: bulk message failed: -22 (1/0)
>>>>>   ...
>>>>>   dvb-usb: bulk message failed: -22 (1/0)
>>>>>
>>>>> Looking into the codes, there is a loop in dvb_usb_read_remote_control(),
>>>>> that is in rc_core_dvb_usb_remote_init() create a work that will call
>>>>> dvb_usb_read_remote_control(), and this work will reschedule itself at
>>>>> 'rc_interval' intervals to recursively call dvb_usb_read_remote_control(),
>>>>> see following code snippet:
>>>> [...]
>>>>
>>>> This patch, as part of v6.10.3-rc3 breaks my TeVii s480 dual DVB-S2
>>>> card, reverting just this patch from v6.10-rc3 fixes the situation
>>>> again (a co-installed Microsoft Xbox One Digital TV DVB-T2 Tuner
>>>> keeps working).
>>> [...]
>>>
>>> Btw. I can also reproduce this (both breakage and 'fix' by reverting
>>> this patch) on a another x86_64 system that only has a single TeVii
>>> s480 dual DVB-S2 card (and no further v4l devices) installed. So I'm
>>> seeing this on both sandy-bridge and raptor-lake x86_64 systems.
>>
>> This issue is also present in current linux HEAD (as of this moment,
>> v6.11-rc1-63-g21b136cc63d2).
>>
>> A clean revert of this commit 2052138b7da52ad5ccaf74f736d00f39a1c9198c
>> "media: dvb-usb: Fix unexpected infinite loop in
>> dvb_usb_read_remote_control()" avoids the problem for v6.11~ as well.
> 
> As this issue is in Linus's tree, please work to get it resolved there
> first and then we will gladly take the changes here

Sean, I assume you'll look into this?

Regards,

	Hans

(Added a Cc to the linux-media ML)




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux