On Sat, Aug 03, 2024 at 11:28:02AM +0800, Sean Whitton wrote: > Hello, > > On Tue 30 Jul 2024 at 08:38am +02, Greg Kroah-Hartman wrote: > > > This isn't a "complex values", and really should just be removed > > entirely and use the correct "static inline" properly. > > I found that there are several headers in > atomisp/pci/hive_isp_css_include which have this pattern of defining an > _INLINE_*_ preprocessor constant, and using it to choose between > 'extern' and 'static inline' in each file where the header is included. > > I don't know what the author's intention was. Are you saying that you > think this preprocessor mechanism should just be replaced with > hardcoding 'extern' or 'static inline' in each file which includes one > of these headers? *You* need to figure out what the proper thing is. Not us. That's the difficult part of writing a patch. Once you know what the correct thing is, then the rest is just typing. That business of defining STORAGE_CLASS_SP_C is weird. Figure out the authors intention and find a better way to do it. Figure out why your code compiled as well because putting parentheses around (static inline) is a syntax error. regards, dan carpenter
