Re: [PATCH 09/13] media: qcom: camss: Add CSID Gen3 support for SM8550

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bryan,

On 8/1/2024 7:14 PM, Bryan O'Donoghue wrote:
On 01/08/2024 11:59, Bryan O'Donoghue wrote:
for preference every single patch applies and builds warning free.

Oops mistyped

- Every patch must apply cleanly
- You could make an argument for some specific cases that
   a patch can generate a warning provided
- By the end of your set everything must be warning free

In this case though, I don't believe you need to make that case since, the problem you describe about probe() isn't a problem at all as you have no upstream dts that can drive the probe() at this point.

Just do the dts at the end and no problem.


Thanks for the confirmation, maybe also can add a checking for the res, probe returns fail if the .data->xxx_res is NULL.


Thanks,
Depeng




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux