Le mar. 30 juil. 2024 à 15:29, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> a écrit : [...] > > + mtk_seninf_update(priv, SENINF_TOP_PHY_SENINF_CTL_CSI0, DPHY_MODE, 0 /* 4D1C*/); > > As this is a V4L2 driver, I'm pretty sure someone will ask for > > mtk_seninf_update(priv, SENINF_TOP_PHY_SENINF_CTL_CSI0, > DPHY_MODE, 0 /* 4D1C*/); > > I wouldn't care too much about going slightly over 80 characters, but > getting close to 100 where lines could be wrapped without hindering > readability will likely upset some people. Same in other places where > applicable. > Hi Laurent, On an early version of this series, Angelo asked me to un-wrap lines that can fit into 100 chars... Both are fine for me, we just need to agree on something here .... [...] > > + /* Configure timestamp */ > > + writel(SENINF_TIMESTAMP_STEP, input->base + SENINF_TG1_TM_STP); > > Can we have a mtk_seninf_input_write(), the same way we have > mtk_seninf_mux_write() ? Same for writes to priv->base below, with a > mtk_seninf_write() inline function. > ... and here :) In an early review Angelo also asked me to remove these accessors. I can add them back and reduce line chars if needed. Cheers Julien
